Update primary name flows to account for default reverse registry#1102
Open
storywithoutend wants to merge 6 commits intomainfrom
Open
Update primary name flows to account for default reverse registry#1102storywithoutend wants to merge 6 commits intomainfrom
storywithoutend wants to merge 6 commits intomainfrom
Conversation
Add support for the default reverse registry in primary name flows: - Add useDefaultReverseRegistryName hook to query default registry - Add usePrimaryNameFromSources hook to combine L1 and default sources - Add setDefaultPrimaryName and resetDefaultPrimaryName transactions - Update ResetPrimaryName flow to handle both registries - Update SelectPrimaryName to use new primary name source hook - Add translations for new transaction types
Fix variable shadowing in usePrimaryNameFromSources by using query object access instead of destructuring. Update test mocks to use usePrimaryNameFromSources instead of useReverseRegistryName. Add e2e test fixtures for primary name state management.
Deploying ens-app-v3 with
|
| Latest commit: |
273bef4
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2244893b.ens-app-v3.pages.dev |
| Branch Preview URL: | https://feature-fet-2789-managerv3-u.ens-app-v3.pages.dev |
…ryName fixture Remove dependency on @ensdomains/ensjs/wallet and @ensdomains/ensjs/contracts imports which cause ESM compatibility issues with Playwright's CommonJS runtime. Replace with inline ABI definitions and direct contract calls using viem's encodeFunctionData. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
When clearing the L1 primary name via setPrimaryNameState, the code would attempt to call setResolver on the ENS Registry even when no resolver existed. This caused transaction reverts because the user doesn't own the reverse node until a primary name is set. Now queries the current resolver first and only attempts to clear it if one exists, preventing errors when clearAll is called before any L1 primary name has been set.
Replace direct ensjs/wallet setPrimaryName calls with the setPrimaryNameState fixture function for consistency across tests. Update test expectations to reflect default registry behavior when no L1 primary name exists.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.